Skip to content

Conversation

@osalyk
Copy link
Contributor

@osalyk osalyk commented Jan 14, 2026

This change is Reviewable

Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janekmi reviewed all commit messages and made 1 comment.
Reviewable status: 0 of 11 files reviewed, 1 unresolved discussion (waiting on @grom72 and @osalyk).


src/test/pmempool_sync/TEST43 line 59 at r1 (raw file):

create_recovery_file $DIR/testset1_r1_p2_badblocks.txt

turn_on_checking_bad_blocks $POOLSET

Can we remove all of these in one go?

Copy link
Contributor Author

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@osalyk made 1 comment.
Reviewable status: 0 of 16 files reviewed, 1 unresolved discussion (waiting on @grom72 and @janekmi).


src/test/pmempool_sync/TEST43 line 59 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

Can we remove all of these in one go?

Done.

Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janekmi reviewed 16 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72).


a discussion (no related file):
Whoever will merge this it would be good to mention #28 in the commit message.

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grom72 made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @osalyk).


a discussion (no related file):

Previously, janekmi (Jan Michalski) wrote…

Whoever will merge this it would be good to mention #28 in the commit message.

So this should be added to the commit message.

Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janekmi made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @osalyk).


a discussion (no related file):

Previously, grom72 (Tomasz Gromadzki) wrote…

So this should be added to the commit message.

Yes. But it can be done while squashing.

@osalyk
Copy link
Contributor Author

osalyk commented Jan 15, 2026

@grom72 made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @osalyk).

a discussion (no related file):

Previously, janekmi (Jan Michalski) wrote…
So this should be added to the commit message.

Done.

Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janekmi reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @osalyk).

@osalyk
Copy link
Contributor Author

osalyk commented Jan 15, 2026

@grom72 @janekmi as discussed, the tests have been corrected.

Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@janekmi reviewed 30 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @osalyk).

@janekmi janekmi requested a review from grom72 January 15, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants